Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outlined icons #452

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix outlined icons #452

merged 1 commit into from
Mar 7, 2024

Conversation

smartspot2
Copy link
Member

Some icons that are not filled were incorrectly filled in by the prior SCSS transition; this should be fixed now through the addition of a new outline class for icons, which sets the fill to none.

@smartspot2 smartspot2 added the bug Something isn't working label Oct 30, 2023
@smartspot2 smartspot2 self-assigned this Oct 30, 2023
@cypress
Copy link

cypress bot commented Oct 30, 2023

Passing run #321 ↗︎

0 78 0 0 Flakiness 0

Details:

Fix outlined icons (#452)
Project: csm_web Commit: 2760930e14
Status: Passed Duration: 01:55 💡
Started: Mar 7, 2024 10:03 PM Ended: Mar 7, 2024 10:05 PM

Review all test suite changes for PR #452 ↗︎

Copy link

@jacovkim jacovkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smartspot2 smartspot2 merged commit 2760930 into master Mar 7, 2024
16 checks passed
@smartspot2 smartspot2 deleted the fix/icon-fix branch March 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants